Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw and exception when raise on error is set to false #293

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

Tasty213
Copy link
Contributor

As raised in #276 and in compliance with the specification make it so that running the detect method on a detector with raise_on_error set to false doesn't throw an exception if it can't find any GCP resources.

@Tasty213 Tasty213 requested a review from a team as a code owner October 23, 2023 20:14
@google-cla
Copy link

google-cla bot commented Oct 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aabmass
Copy link
Collaborator

aabmass commented Oct 27, 2023

@Tasty213 can you sign the CLA?

@Tasty213
Copy link
Contributor Author

I think I've already done so? The check shows as passed

@Tasty213
Copy link
Contributor Author

fixed the linter error

@aabmass
Copy link
Collaborator

aabmass commented Oct 30, 2023

/gcbrun

@Tasty213
Copy link
Contributor Author

Tasty213 commented Oct 30, 2023

Could've sworn the linter passed locally

@aabmass
Copy link
Collaborator

aabmass commented Oct 30, 2023

Could've sworn the linter passed locally

Could be some weird flake in the CI setup. Lmk if you have trouble getting it to pass in CI and I can try to fix it

@Tasty213
Copy link
Contributor Author

Tasty213 commented Nov 1, 2023

Figured out what was wrong with my local testing, I use Windows and have git to checkout CRLF and commit LF, so when I ran the linter locally every single file threw a warning as it was in the 'wrong' line ending style giving pylint unexpected-line-ending-format. I've set pycharm to force everything in the project to LF but now git reckons I've changed every file (until I try and stage and it realises I haven't).

Either way this should now pass the lint step.

@aabmass
Copy link
Collaborator

aabmass commented Nov 2, 2023

/gcbrun

Copy link
Collaborator

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@aabmass aabmass enabled auto-merge (squash) November 2, 2023 20:15
@aabmass aabmass merged commit 0b37f88 into GoogleCloudPlatform:main Nov 2, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants