Detect the managed instance group that created a VM #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
==========================================
+ Coverage 61.03% 63.55% +2.51%
==========================================
Files 56 57 +1
Lines 5903 6058 +155
==========================================
+ Hits 3603 3850 +247
+ Misses 2143 2046 -97
- Partials 157 162 +5 ☔ View full report in Codecov by Sentry. |
quentinmit
force-pushed
the
mig-detection
branch
from
166eefb
to
b10fc48
Compare
dashpole
reviewed
Sep 24, 2024
…, and run most tests with a complete set of basic metadata
dashpole
reviewed
Sep 25, 2024
dashpole
approved these changes
Sep 26, 2024
|
Code changes LGTM. Please document the steps you took to manually test this PR in the description before merging. |
|
Just add the missing license header in the print_test, and this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for new resource attributes for the MIG.