Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timeout in Collector Logs exporter #894

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

damemi
Copy link
Member

@damemi damemi commented Sep 17, 2024

@damemi damemi requested a review from a team as a code owner September 17, 2024 19:54
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.85%. Comparing base (4caace7) to head (ac62f2c).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
exporter/collector/logs.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   61.03%   62.85%   +1.82%     
==========================================
  Files          56       57       +1     
  Lines        5903     6023     +120     
==========================================
+ Hits         3603     3786     +183     
+ Misses       2143     2075      -68     
- Partials      157      162       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damemi damemi merged commit d6795b4 into GoogleCloudPlatform:main Sep 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants