-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collector example #657
Conversation
Codecov Report
@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 68.47% 68.39% -0.09%
==========================================
Files 36 36
Lines 4559 4559
==========================================
- Hits 3122 3118 -4
- Misses 1284 1288 +4
Partials 153 153 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the gitignore to exclude the new example/metric/collector/metrics
binary
example/metric/README.md
Outdated
1. Exporting metrics via the SDK. | ||
2. Exporting metrics via the OpenTelemetry Collector. | ||
|
||
Change the current directory to the example you wish to run - either to `sdk` directory or `collector` directory and then run the example using following commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Exporting metrics via the SDK. | |
2. Exporting metrics via the OpenTelemetry Collector. | |
Change the current directory to the example you wish to run - either to `sdk` directory or `collector` directory and then run the example using following commands: | |
1. Exporting metrics via the [SDK](sdk). | |
2. Exporting metrics via the [OpenTelemetry Collector](collector). | |
Change the current directory to the example you wish to run - either to [`sdk`](sdk) directory or [`collector`](collector) directory and then run the example using following commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the text "SDK" and "OpenTelemetry Collector" in the bullet points should not be a hyperlink to the folders since they are actually intended to explain what component is being used to export metrics.
I will add hyperlinks in the instructions though.
8a95be2
to
d3a6551
Compare
5e0e1fa
to
a885b1e
Compare
Only the files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only suggestion would be to just drop the debugging exporters, otherwise lgtm
This PR adds OpenTelemetry Collector based example for metrics export.
Also fixes misconfigured metrics-dashboard json