Add stale fixture data point #645
Conversation
| @@ -51,6 +51,19 @@ | |||
| ] | |||
| } | |||
| }, | |||
| { | |||
| "name":"scrape_series_added", | |||
There was a problem hiding this comment.
nit could you give rename this one to indicate what it's testing
There was a problem hiding this comment.
I wanted this to show that it worked for an existing metric that has valid data points, so I moved this to its own test that explains it better
damemi
force-pushed
the
drop-stale-points
branch
from
3ea2485
to
86a3d13
Compare
| OTLPInputFixturePath: "testdata/fixtures/metrics/basic_prometheus_metrics_stale.json", | ||
| ExpectFixturePath: "testdata/fixtures/metrics/basic_prometheus_metrics_stale_expect.json", | ||
| CompareFixturePath: "testdata/fixtures/metrics/basic_prometheus_metrics_expect.json", | ||
| SkipForSDK: true, |
There was a problem hiding this comment.
@dashpole should our sdk exporter drop stale points too? This failed for sdk and I didn't see anything handling stale points there
There was a problem hiding this comment.
The SDK shouldn't have a notion of stale points. I.e. it shouldn't be possible to get those when coming from the SDK.
There was a problem hiding this comment.
ah because it's just a prometheus thing right? So it's only possible from the prom receiver, that makes sense
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 66.47% 68.31% +1.84%
==========================================
Files 36 36
Lines 4301 4539 +238
==========================================
+ Hits 2859 3101 +242
+ Misses 1314 1285 -29
- Partials 128 153 +25
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adding a test to show that we drop data points with
NO_RECORDED_VALUE_MASKset