Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added block interface and memory block implementations. #2600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vadlakondaswetha
Copy link
Collaborator

Description

Added block interface and memory block implementation

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - N/A since this is standlone class for now
  2. Unit tests - Added
  3. Integration tests - N/A

@vadlakondaswetha vadlakondaswetha requested a review from a team as a code owner October 16, 2024 06:30
@kislaykishore kislaykishore requested review from a team, BrennaEpp and kislaykishore and removed request for a team, BrennaEpp and kislaykishore October 16, 2024 06:30
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (6d24bbd) to head (8468693).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/block/block.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
- Coverage   78.13%   78.06%   -0.07%     
==========================================
  Files         107      108       +1     
  Lines       11844    11860      +16     
==========================================
+ Hits         9254     9259       +5     
- Misses       2083     2091       +8     
- Partials      507      510       +3     
Flag Coverage Δ
unittests 78.06% <87.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant