Replaced gcloud command with control client code in Create/DeleteManagedFoldersInBucket in managed_folders test package #2596
+103
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
kislaykishore,
gargnitingoogle and
tritone
and removed request for
a team,
kislaykishore and
gargnitingoogle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2596 +/- ##
==========================================
- Coverage 78.10% 78.00% -0.11%
==========================================
Files 107 107
Lines 11844 11844
==========================================
- Hits 9251 9239 -12
- Misses 2086 2100 +14
+ Partials 507 505 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
reviewed
Oct 15, 2024
Tulsishah
previously approved these changes
Oct 15, 2024
Tulsishah
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced gcloud command in helper function in managed folders test package, using control client to :
Motivation: gcloud commands can't be run concurrently as part of parallelizing CD tests.Thus, needs to be replaced.
Link to the issue in case of a bug fix.
NA
Testing details