[unsupported-object-issue-fix part1] Prep for fix empty directory list issue #2561
+151
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
tritone and
kislaykishore
and removed request for
a team and
tritone
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
- Coverage 78.13% 78.07% -0.06%
==========================================
Files 107 108 +1
Lines 11844 11855 +11
==========================================
+ Hits 9254 9256 +2
- Misses 2083 2090 +7
- Partials 507 509 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gargnitingoogle
force-pushed
the
gargnitin/prep-for-fix-empty-directory-list-issue
branch
from
60257eb
to
5b91951
Compare
gargnitingoogle
requested review from
Tulsishah
and removed request for
ashmeenkaur and
kislaykishore
Tulsishah
reviewed
Oct 14, 2024
gargnitingoogle
force-pushed
the
gargnitin/prep-for-fix-empty-directory-list-issue
branch
from
5b91951
to
8e82656
Compare
Tulsishah
previously approved these changes
Oct 14, 2024
gargnitingoogle
force-pushed
the
gargnitin/prep-for-fix-empty-directory-list-issue
branch
from
4b9c32a
to
c782b7f
Compare
Tulsishah
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds utility for ignoring GCS objects which aren't supported in GCSFuse mounts. These objects have
//in their names or have names starting with/. These can't be represented in linux FS, hence need to be ignored in GCSFuse mount.This is followed up in #1876 (implementation) and e2e tests (#2011) .
Link to the issue in case of a bug fix.
NA
Testing details