Enabling debug logs for rename perf test #2509
Draft
+42
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
BrennaEpp,
kislaykishore and
gargnitingoogle
and removed request for
a team,
BrennaEpp and
kislaykishore
Tulsishah
reviewed
Sep 18, 2024
perfmetrics/scripts/hns_rename_folders_metrics/run_rename_benchmark.sh
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark_test.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark_test.py
Outdated
Show resolved
Hide resolved
Tulsishah
reviewed
Sep 18, 2024
anushka567
force-pushed
the
hns-rename-benchmark-upgrade-gcloud
branch
from
3b8989b
to
a3c5ced
Compare
anushka567
changed the title
gargnitingoogle
requested changes
Sep 18, 2024
| else : | ||
| # Creating config file for mounting with hns disabled. | ||
| with open("/tmp/config.yml",'w') as mount_config: | ||
| mount_config.write("enable-hns: false") | ||
| mount_flags = "--config-file=/tmp/config.yml --implicit-dirs --rename-dir-limit=1000000 --stackdriver-export-interval=30s" | ||
| mount_flags = "--config-file=/tmp/config.yml --log-severity=trace --log-format \"text\" --log-file {} --implicit-dirs --rename-dir-limit=1000000 --stackdriver-export-interval=30s".format(LOG_FILE) |
There was a problem hiding this comment.
Adding trace-logging affect the performance of the test run. Is that accounted for in thresholds ?
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
| @@ -133,7 +133,7 @@ def test_perform_testing_flat(self, mock_log, mock_record_time_of_operation, | |||
| test_type = "flat" | |||
| num_samples = 4 | |||
| results = {} | |||
| mount_flags = "--config-file=/tmp/config.yml --implicit-dirs --rename-dir-limit=1000000 --stackdriver-export-interval=30s" | |||
| mount_flags = "--config-file=/tmp/config.yml --log-severity=trace --log-format \"text\" --log-file /tmp/gcsfuse-logs-rename.txt --implicit-dirs --rename-dir-limit=1000000 --stackdriver-export-interval=30s" | |||
There was a problem hiding this comment.
Same question as above about the performance issue with log-severity trace.
| export PATH=/usr/local/google-cloud-sdk/bin:$PATH | ||
| echo 'export PATH=/usr/local/google-cloud-sdk/bin:$PATH' >> ~/.bashrc | ||
| gcloud version && rm gcloud.tar.gz | ||
| sudo /usr/local/google-cloud-sdk/bin/gcloud components update |
There was a problem hiding this comment.
I don't think we need the full path to gcloud here as we have already update the PATH variable locally.
Suggested change
| sudo /usr/local/google-cloud-sdk/bin/gcloud components update | |
| sudo gcloud components update |
There was a problem hiding this comment.
While trying to do this, I was facing this issue
ERROR: (gcloud.components.update) You cannot perform this action because this Google Cloud CLI installation is managed by an external package manager.
Please consider using a separate installation of the Google Cloud CLI created through the default mechanism described at: https://cloud.google.com/sdk/
but this did not come up when using sudo /usr/local/google-cloud-sdk/bin/gcloud components update
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark_test.py
Show resolved
Hide resolved
perfmetrics/scripts/hns_rename_folders_metrics/run_rename_benchmark.sh
Outdated
Show resolved
Hide resolved
anushka567
force-pushed
the
hns-rename-benchmark-upgrade-gcloud
branch
from
a3c5ced
to
b79a9c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2509 +/- ##
==========================================
+ Coverage 78.85% 78.90% +0.05%
==========================================
Files 106 106
Lines 11686 11686
==========================================
+ Hits 9215 9221 +6
+ Misses 1992 1987 -5
+ Partials 479 478 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anushka567
force-pushed
the
hns-rename-benchmark-upgrade-gcloud
branch
from
ddf6c78
to
117db8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled debug logs for rename perf test
Link to the issue in case of a bug fix.
NA
Testing details