Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unit of ops and file-cache latency metrics to microseconds #2380

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Aug 22, 2024

  • ops_latency and file-cache-latency are best represent in microseconds and not millseconds since many operations take less than a millisecond to complete.
  • Also change the metric datatype from Float64 to int64.

Description

Now, the operations are appearing in a non-zero latency bucket.
image

as opposed to the current situation where most operations fall in the zero-bucket:
image

Same for file-cache:
image

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

ops_latency is best represent in microseconds and not millseconds since
many operations take less than a millisecond to complete.
@kislaykishore kislaykishore requested a review from a team as a code owner August 22, 2024 06:42
internal/fs/wrappers/monitoring.go Outdated Show resolved Hide resolved
internal/fs/wrappers/monitoring.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore changed the title Change unit of ops_latency metric to microseconds Change unit of ops and file-cache latency metrics to microseconds Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.09%. Comparing base (617168e) to head (e984310).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2380      +/-   ##
==========================================
+ Coverage   79.04%   79.09%   +0.04%     
==========================================
  Files         105      105              
  Lines       11577    11575       -2     
==========================================
+ Hits         9151     9155       +4     
+ Misses       1961     1956       -5     
+ Partials      465      464       -1     
Flag Coverage Δ
unittests 79.09% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore merged commit 4638976 into master Aug 23, 2024
13 of 14 checks passed
@kislaykishore kislaykishore deleted the prometheus branch August 23, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants