-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write test failure on some machines because of gsutil download #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
September 22, 2023 06:55
Tulsishah
changed the title
[Don't review]Write test failure on some machines because of gsutil download
Write test failure on some machines because of gsutil download
Sep 22, 2023
raj-prince
reviewed
Sep 22, 2023
raj-prince
reviewed
Sep 22, 2023
raj-prince
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check.
Tulsishah
force-pushed
the
write_test_failure_on_some_machines
branch
from
September 22, 2023 10:55
73517a4
to
ef1e8fb
Compare
Tulsishah
commented
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check @raj-prince
raj-prince
reviewed
Sep 22, 2023
raj-prince
reviewed
Sep 22, 2023
raj-prince
reviewed
Sep 22, 2023
raj-prince
approved these changes
Sep 23, 2023
gargnitingoogle
pushed a commit
that referenced
this pull request
Oct 4, 2023
* adding crcmod installation steps * small fix * small fix * small fix * testing * adding requiremets * adding requiremets * adding requiremets * adding requiremets * fixing * small fix * small fix * setting req * setting req * formating * creating dir * formating * formating * fix * insatallting with python3 * small fix
gargnitingoogle
pushed a commit
that referenced
this pull request
Oct 30, 2023
* adding crcmod installation steps * small fix * small fix * small fix * testing * adding requiremets * adding requiremets * adding requiremets * adding requiremets * fixing * small fix * small fix * setting req * setting req * formating * creating dir * formating * formating * fix * insatallting with python3 * small fix
gargnitingoogle
pushed a commit
that referenced
this pull request
Oct 31, 2023
* adding crcmod installation steps * small fix * small fix * small fix * testing * adding requiremets * adding requiremets * adding requiremets * adding requiremets * fixing * small fix * small fix * setting req * setting req * formating * creating dir * formating * formating * fix * insatallting with python3 * small fix
gargnitingoogle
pushed a commit
that referenced
this pull request
Nov 1, 2023
* adding crcmod installation steps * small fix * small fix * small fix * testing * adding requiremets * adding requiremets * adding requiremets * adding requiremets * fixing * small fix * small fix * setting req * setting req * formating * creating dir * formating * formating * fix * insatallting with python3 * small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While running e2e tests on louhi pipeline I found that some e2e tests are failing while coping file using gsutil.
These thing is happing only on some machines and not all machines.
The error is
==> NOTE: You are downloading one or more large file(s), which would
run significantly faster if you enabled sliced object downloads. This
feature is enabled by default but requires that compiled crcmod be
installed (see "gsutil help crcmod").
CommandException:
Downloading this composite object requires integrity checking with CRC32c,
but your crcmod installation isn't using the module's C extension, so the
hash computation will likely throttle download performance. For help
installing the extension, please see "gsutil help crcmod".
To download regardless of crcmod performance or to skip slow integrity
checks, see the "check_hashes" option in your boto config file.
NOTE: It is strongly recommended that you not disable integrity checks. Doing so
could allow data corruption to go undetected during uploading/downloading.
This requires to install crcmod python library.
Link to the issue in case of a bug fix.
NA
Testing details