Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test failure on some machines because of gsutil download #1392

Merged
merged 21 commits into from
Sep 23, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Sep 22, 2023

Description

While running e2e tests on louhi pipeline I found that some e2e tests are failing while coping file using gsutil.

These thing is happing only on some machines and not all machines.

The error is
==> NOTE: You are downloading one or more large file(s), which would            
run significantly faster if you enabled sliced object downloads. This
feature is enabled by default but requires that compiled crcmod be
installed (see "gsutil help crcmod").

CommandException: 
Downloading this composite object requires integrity checking with CRC32c,
but your crcmod installation isn't using the module's C extension, so the
hash computation will likely throttle download performance. For help
installing the extension, please see "gsutil help crcmod".

To download regardless of crcmod performance or to skip slow integrity
checks, see the "check_hashes" option in your boto config file.

NOTE: It is strongly recommended that you not disable integrity checks. Doing so
could allow data corruption to go undetected during uploading/downloading.

This requires to install crcmod python library.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested on louhi pipeline
  2. Unit tests - NA
  3. Integration tests - NA

@Tulsishah Tulsishah changed the title [Don't review]Write test failure on some machines because of gsutil download Write test failure on some machines because of gsutil download Sep 22, 2023
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check.

@Tulsishah Tulsishah force-pushed the write_test_failure_on_some_machines branch from 73517a4 to ef1e8fb Compare September 22, 2023 10:55
Copy link
Collaborator Author

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check @raj-prince

@Tulsishah Tulsishah merged commit f75dfa2 into master Sep 23, 2023
8 checks passed
gargnitingoogle pushed a commit that referenced this pull request Oct 4, 2023
* adding crcmod installation steps

* small fix

* small fix

* small fix

* testing

* adding requiremets

* adding requiremets

* adding requiremets

* adding requiremets

* fixing

* small fix

* small fix

* setting req

* setting req

* formating

* creating dir

* formating

* formating

* fix

* insatallting with python3

* small fix
gargnitingoogle pushed a commit that referenced this pull request Oct 30, 2023
* adding crcmod installation steps

* small fix

* small fix

* small fix

* testing

* adding requiremets

* adding requiremets

* adding requiremets

* adding requiremets

* fixing

* small fix

* small fix

* setting req

* setting req

* formating

* creating dir

* formating

* formating

* fix

* insatallting with python3

* small fix
gargnitingoogle pushed a commit that referenced this pull request Oct 31, 2023
* adding crcmod installation steps

* small fix

* small fix

* small fix

* testing

* adding requiremets

* adding requiremets

* adding requiremets

* adding requiremets

* fixing

* small fix

* small fix

* setting req

* setting req

* formating

* creating dir

* formating

* formating

* fix

* insatallting with python3

* small fix
gargnitingoogle pushed a commit that referenced this pull request Nov 1, 2023
* adding crcmod installation steps

* small fix

* small fix

* small fix

* testing

* adding requiremets

* adding requiremets

* adding requiremets

* adding requiremets

* fixing

* small fix

* small fix

* setting req

* setting req

* formating

* creating dir

* formating

* formating

* fix

* insatallting with python3

* small fix
@Tulsishah Tulsishah deleted the write_test_failure_on_some_machines branch July 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants