Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests to verify that file creation does not creates file on GCS until synced. #1382

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Sep 19, 2023

Description

Added integration tests to verify that file creation does not creates file on GCS until synced.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual -
  • Manually ran on GCP VM using the following commands:
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/...  -p 1 --integrationTest -v --testbucket=$TEST_BUCKET_NAME
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/...  -p 1 --integrationTest -v --testbucket=$TEST_BUCKET_NAME --testInstalledPackage
  • Ran the following commands for mounted directory tests
# package local_file
# Run test with static mounting. (flags: --implicit-dirs=true)
gcsfuse --implicit-dirs=true --rename-dir-limit=3 $TEST_BUCKET_NAME $MOUNT_DIR
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/... -p 1 --integrationTest -v --mountedDirectory=$MOUNT_DIR --testbucket=$TEST_BUCKET_NAME
sudo umount $MOUNT_DIR

# Run test with static mounting. (flags: --implicit-dirs=false)
gcsfuse --implicit-dirs=false --rename-dir-limit=3 $TEST_BUCKET_NAME $MOUNT_DIR
GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/local_file/... -p 1 --integrationTest -v --mountedDirectory=$MOUNT_DIR --testbucket=$TEST_BUCKET_NAME
sudo umount $MOUNT_DIR
  1. Unit tests - NA
  2. Integration tests - NA

@ashmeenkaur ashmeenkaur added the execute-integration-tests Run only integration tests label Sep 19, 2023
@ashmeenkaur ashmeenkaur changed the title Integration tests to verify that file creation does not creates file on GCS until synced. Integration tests to verify that file creation does not creates file on GCS until synced. [ready for review] Sep 19, 2023
@ashmeenkaur ashmeenkaur changed the title Integration tests to verify that file creation does not creates file on GCS until synced. [ready for review] [ready for review] Integration tests to verify that file creation does not creates file on GCS until synced. Sep 19, 2023
@ashmeenkaur ashmeenkaur changed the base branch from implicit_dir_local_file_test to master September 20, 2023 07:59
@ashmeenkaur ashmeenkaur changed the title [ready for review] Integration tests to verify that file creation does not creates file on GCS until synced. Integration tests to verify that file creation does not creates file on GCS until synced. Sep 20, 2023
@ashmeenkaur ashmeenkaur added execute-integration-tests Run only integration tests and removed execute-integration-tests Run only integration tests labels Sep 20, 2023
@ashmeenkaur ashmeenkaur merged commit ee62245 into master Sep 20, 2023
8 checks passed
@ashmeenkaur ashmeenkaur deleted the create_local_file_test branch September 20, 2023 11:41
@ashmeenkaur ashmeenkaur added remove-0-byte-file-changes and removed execute-integration-tests Run only integration tests labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants