Skip to content

Commit

Permalink
Un-deprecate create-empty-file flag (#2583)
Browse files Browse the repository at this point in the history
The create-empty-file flag helps in cases where local files are
involved. So, we cannot deprecate it unless we have a viable
alternative. Un-deprecate it.
  • Loading branch information
kislaykishore authored Oct 14, 2024
1 parent 21f7eab commit cc2ecbb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions cfg/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,6 @@ func BuildFlagSet(flagSet *pflag.FlagSet) error {

flagSet.BoolP("create-empty-file", "", false, "For a new file, it creates an empty file in Cloud Storage bucket as a hold.")

if err := flagSet.MarkDeprecated("create-empty-file", "This flag will be deleted soon."); err != nil {
return err
}

flagSet.StringP("custom-endpoint", "", "", "Specifies an alternative custom endpoint for fetching data. Should only be used for testing. The custom endpoint must support the equivalent resources and operations as the GCS JSON endpoint, https://storage.googleapis.com/storage/v1. If a custom endpoint is not specified, GCSFuse uses the global GCS JSON API endpoint, https://storage.googleapis.com/storage/v1.")

flagSet.BoolP("debug_fs", "", false, "This flag is unused.")
Expand Down
2 changes: 0 additions & 2 deletions cfg/params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,6 @@
usage: "For a new file, it creates an empty file in Cloud Storage bucket as a
hold."
default: false
deprecated: true
deprecation-warning: "This flag will be deleted soon."

- config-path: "write.experimental-enable-streaming-writes"
flag-name: "experimental-enable-streaming-writes"
Expand Down

0 comments on commit cc2ecbb

Please sign in to comment.