Undo from spark-2.X

GoogleCloudDataproc · Jul 29, 2023 · 47456df · 47456df
1 parent 05a94db
commit 47456df
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 73 deletions.
diff --git a/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerBatch.java b/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerBatch.java
diff --git a/....1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerDataReaderFactory.java b/....1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerDataReaderFactory.java
diff --git a/...loud/spark/spanner/SpannerDataReader.java → ...loud/spark/spanner/SpannerDataReader_java b/...loud/spark/spanner/SpannerDataReader.java → ...loud/spark/spanner/SpannerDataReader_java
@@ -28,6 +28,6 @@ public boolean next() {
   @Override
   public T get() {
     // TODO: Fill me in.
-    return true;
+    return null;
   }
 }
diff --git a/...park/spanner/SpannerDataSourceReader.java → ...park/spanner/SpannerDataSourceReader_java b/...park/spanner/SpannerDataSourceReader.java → ...park/spanner/SpannerDataSourceReader_java
diff --git a/...-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerPartitionReader.java b/...-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerPartitionReader.java
@@ -17,9 +17,7 @@
 import java.io.IOException;
 import org.apache.spark.sql.catalyst.InternalRow;
 import org.apache.spark.sql.connector.read.Batch;
-import org.apache.spark.sql.connector.read.ColumnarBatch;
 import org.apache.spark.sql.connector.read.InputPartition;
-import org.apache.spark.sql.connector.read.Partition;
 import org.apache.spark.sql.connector.read.PartitionReader;
 import org.apache.spark.sql.connector.read.Scan;
 import org.apache.spark.sql.types.StructType;
@@ -43,7 +41,6 @@ public void close() throws IOException {
     // TODO: Fill me in.
   }
 
-  @Override
   public boolean supportsColumnarReads(InputPartition partition) {
     // TODO: Fill me in.
     return false;

diff --git a/...panner/SpannerPartitionReaderFactory.java → ...panner/SpannerPartitionReaderFactory_java b/...panner/SpannerPartitionReaderFactory.java → ...panner/SpannerPartitionReaderFactory_java
diff --git a/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerSpark.java b/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerSpark.java
@@ -29,6 +29,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
@@ -42,17 +43,15 @@
 import org.apache.spark.sql.SparkSession;
 import org.apache.spark.sql.connector.catalog.SupportsRead;
 import org.apache.spark.sql.connector.catalog.Table;
+import org.apache.spark.sql.connector.catalog.TableCapability;
 import org.apache.spark.sql.connector.catalog.TableProvider;
 import org.apache.spark.sql.connector.expressions.Transform;
 import org.apache.spark.sql.connector.read.PartitionReader;
 import org.apache.spark.sql.connector.read.ScanBuilder;
-import org.apache.spark.sql.sources.v2.DataSource;
-import org.apache.spark.sql.sources.v2.reader.DataSourceOptions;
-import org.apache.spark.sql.sources.v2.reader.DataSourceReader;
 import org.apache.spark.sql.types.StructType;
 import org.apache.spark.sql.util.CaseInsensitiveStringMap;
 
-public class SpannerSpark implements TableProvider, SupportsRead, ReadSupport {
+public class SpannerSpark implements TableProvider, SupportsRead {
   private BatchClient batchClient;
   private Map<String, String> properties;
 
@@ -195,16 +194,23 @@ public ScanBuilder newScanBuilder(CaseInsensitiveStringMap options) {
     return new SpannerScanBuilder(options);
   }
 
+  @Override
+  public Set<TableCapability> capabilities() {
+    return null;
+  }
+
   @Override
   public Map<String, String> properties() {
     return this.properties;
   }
 
-  /*
-   * The entry point to create a reader.
-   */
   @Override
-  public DataSourceReader createReader(DataSourceOptions options) {
-    return new SpannerDataSourceReader(options);
+  public String name() {
+    return "spanner";
+  }
+
+  @Override
+  public StructType schema() {
+    return null;
   }
 }
diff --git a/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerTable.java b/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerTable.java
@@ -83,6 +83,7 @@ public StructType createSchema(String tableName, ResultSet rs) {
       }
     }
     this.tableSchema = schema;
+    return schema;
   }
 
   public static DataType ofSpannerStrType(String spannerStrType) {