Address review feedback

GoogleCloudDataproc · Aug 2, 2023 · 41d3b50 · 41d3b50
1 parent 16b2ce8
commit 41d3b50
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 74 deletions.
diff --git a/examples/SpannerSpark.java b/examples/SpannerSpark.java
@@ -27,7 +27,7 @@ public static void main(String[] args) {
 
 
         Dataset<Row> df = spark.read()
-            .format("spanner")
+            .format("cloud-spanner")
             .option("table", "people")
             .option("projectId", "orijtech-161805")
             .option("instanceId", "oragent-ws-spanner")

diff --git a/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/DefaultSource.java b/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/DefaultSource.java
@@ -25,7 +25,7 @@
 public class DefaultSource implements DataSourceRegister, RelationProvider, SchemaRelationProvider {
   @Override
   public String shortName() {
-    return "spanner";
+    return "cloud-spanner";
   }
 
   /*

diff --git a/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerDataReader_java b/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerDataReader_java
diff --git a/...3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerDataSourceReader_java b/...3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerDataSourceReader_java
diff --git a/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerSpark.java b/spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SpannerSpark.java
@@ -215,7 +215,7 @@ public Map<String, String> properties() {
 
   @Override
   public String name() {
-    return "spanner";
+    return "cloud-spanner";
   }
 
   @Override

diff --git a/...spanner-lib/src/main/java/com/google/cloud/spark/spanner/Spark31SpannerTableProvider.java b/...spanner-lib/src/main/java/com/google/cloud/spark/spanner/Spark31SpannerTableProvider.java
@@ -43,6 +43,6 @@ public boolean supportsExternalMetadata() {
 
   @Override
   public String shortName() {
-    return "spanner";
+    return "cloud-spanner";
   }
 }