Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying gRPC buffered read flow (#853) #859

Open
wants to merge 3 commits into
base: branch-2.2.x
Choose a base branch
from

Conversation

abmodi
Copy link
Contributor

@abmodi abmodi commented Aug 17, 2022

  • Simplifying gRPC buffered read flow

  • Addressing CR comments

(cherry picked from commit 96cdbc8)

* Simplifying gRPC buffered read flow

* Addressing CR comments

(cherry picked from commit 96cdbc8)
@abmodi
Copy link
Contributor Author

abmodi commented Aug 17, 2022

/gcbrun

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Base: 80.71% // Head: 80.69% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (770c053) compared to base (e51b0f8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                 @@
##             branch-2.2.x     #859      +/-   ##
==================================================
- Coverage           80.71%   80.69%   -0.02%     
  Complexity           2170     2170              
==================================================
  Files                 151      151              
  Lines                9840     9837       -3     
  Branches             1136     1136              
==================================================
- Hits                 7942     7938       -4     
- Misses               1421     1423       +2     
+ Partials              477      476       -1     
Flag Coverage Δ
hadoop2integrationtest 60.96% <8.33%> (+0.11%) ⬆️
hadoop2unittest 68.60% <100.00%> (-0.03%) ⬇️
hadoop3integrationtest 60.74% <8.33%> (-0.06%) ⬇️
hadoop3unittest 68.63% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adoop/gcsio/GoogleCloudStorageGrpcReadChannel.java 83.70% <100.00%> (-0.14%) ⬇️
...gle/cloud/hadoop/gcsio/GoogleCloudStorageImpl.java 86.72% <0.00%> (-0.20%) ⬇️
...doop/gcsio/GoogleCloudStorageGrpcWriteChannel.java 78.87% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants