Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate aside implementation & add tip type #79
base: main
Are you sure you want to change the base?
Consolidate aside implementation & add tip type #79
Changes from 20 commits
83a0ee3
b273a46
8b43eb9
59d1230
006763a
3a8b29d
4b29370
f1c56d2
e434f1d
b928ef6
651d97f
ad81da0
0ea4548
a9d908b
b457911
ad53429
c522fc1
e6a60da
5c1f9fa
afbdea1
bb49950
d875a84
a415032
3b5235e
4a5426e
ab0a0b8
a102963
c0fca12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor the styles in a way that's not needed anymore. Basically all styles this widget needs should be in styles - they shouldn't rely on anything either web.dev or d.c.c brings or alters. See the BrowserCompat shortcode for reference.
For example you are using
--color-blue-darkest
, which is undefined for web.dev.Define basic styling here and make it configurable using overwritable variables.