deps(lodash): migrate lodash to lodash-es to improve tree-shaking #16211
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherPHolder
requested review from
connorjclark
and removed request for
a team
adamraine
reviewed
Oct 9, 2024
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| /* eslint-disable no-console */ | |||
|
|
|||
| import cloneDeep from 'lodash/cloneDeep.js'; | |||
| import cloneDeep from 'lodash-es/cloneDeep.js'; | |||
There was a problem hiding this comment.
I would expect the advantage of tree-shaking to be that we can import everything from the top-level entry point now. For example:
Suggested change
| import cloneDeep from 'lodash-es/cloneDeep.js'; | |
| import {cloneDeep} from 'lodash-es'; |
Is this something you could do?
There was a problem hiding this comment.
Yes, will make the changes 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve Tree-Shaking and bundling by migrating from
lodashtolodash-es.Even tho we are now using individual imports as of #13914 we are still using ComonJS. But since the rest of the repo seems to have migrated to ESM we can now use the ESM packages for
lodashwhich islodash-es.An addition benefit of this is that if the code is bundles futher by esbuild it will not require wrapping the use of lodash like this:
Related Issues/PRs