core(session): ignore protocol timeouts from puppeteer #15512
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const resultPromise = this._cdpSession.send(method, ...params).catch(err => { | ||
| // We set up our own protocol timeout system, so we should ignore protocol timeouts emitted by puppeteer. | ||
| // https://github.com/GoogleChrome/lighthouse/issues/15510 | ||
| if (/'protocolTimeout'/.test(err)) return; |
There was a problem hiding this comment.
Won't this resolve with undefined, though, if timeoutPromise doesn't win the race?
There was a problem hiding this comment.
Good point. I guess if puppeteer gives us a protocol timeout error that means they are done processing the command. Even if we wait around longer, we won't get a result.
There was a problem hiding this comment.
I suppose an better solution would be to just ignore this type of error for our Page.navigate call specifically? IDK but this clearly needs more work.
|
This won't work because puppeteer will cut off the command response even if Lighthouse is still waiting. I think what we need is for puppeteer to allow setting a timeout on individual commands. |
Fixes #15510