tests: save smokehouse outputs to .tmp/smokehouse-output #15251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jul 11, 2023
There was a problem hiding this comment.
For the DT runner at least we write to disc in debug mode:
https://github.com/GoogleChrome/lighthouse/blob/main/cli/test/smokehouse/lighthouse-runners/devtools.js#L58
Maybe we remove this old logic since it's redundant now?
adamraine
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often I want to inspect the output of the smoke tests, even if they passed (for comparison with a failing patch, for example). So let's write them to disk. It takes ~40ms per smoke run, so it seems fine to do it always (though I disabled it for CI).