Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(extension): update to manifest v3 #15219

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

patrickkettner
Copy link
Contributor

Summary
👋 - patrickkettner@ from extensions devrel here! As a part of our MV2 sunsetting, I am reaching out to popular extensions to see how migrations are going. Even though y'all have shipped in devtools for such a long time, there is still a lot of folks using the extension. I took a quick look, and this was all that is needed to get yall moved over.

@patrickkettner patrickkettner requested a review from a team as a code owner July 4, 2023 03:39
@patrickkettner patrickkettner requested review from brendankenny and removed request for a team July 4, 2023 03:39
@patrickkettner patrickkettner changed the title update extension to manifest v3 clients(extension): update to manifest v3 Jul 4, 2023
@adamraine adamraine added the 11.0 cranked up to eleven label Jul 5, 2023
@adamraine adamraine mentioned this pull request Jul 5, 2023
20 tasks
@paulirish
Copy link
Member

Thanks for the personal touch. :)
Tested this out and it's all aces.

Thanks

@paulirish
Copy link
Member

image

@adamraine afaict this isn't breaking. tbh i think we're fine to deploy this to CWS as soon as its merged. the ext is so small... just a shortcut to opening the viewer.

@patrickkettner
Copy link
Contributor Author

patrickkettner commented Jul 19, 2023

@paulirish wont be breaking, though if someone is running super old chrome (<88ish) then it would break there, as MV3 wasn't around then. we can update the minimum chrome version accordingly, if that is a concern

@devtools-bot devtools-bot merged commit 947c4d5 into GoogleChrome:main Jul 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.0 cranked up to eleven waiting4reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants