core: remove service-worker audit (#15257)

GoogleChrome · Jul 17, 2023 · ff2deca · ff2deca
1 parent b26a6a3
commit ff2deca
Show file tree

Hide file tree

Showing 68 changed files with 416 additions and 2,230 deletions.
diff --git a/cli/test/smokehouse/core-tests.js b/cli/test/smokehouse/core-tests.js
@@ -33,7 +33,6 @@ import metricsTrickyTtiLateFcp from './test-definitions/metrics-tricky-tti-late-
 import offlineOnlineOnly from './test-definitions/offline-online-only.js';
 import offlineReady from './test-definitions/offline-ready.js';
 import offlineSwBroken from './test-definitions/offline-sw-broken.js';
-import offlineSwSlow from './test-definitions/offline-sw-slow.js';
 import oopifRequests from './test-definitions/oopif-requests.js';
 import oopifScripts from './test-definitions/oopif-scripts.js';
 import perfBudgets from './test-definitions/perf-budgets.js';
@@ -97,7 +96,6 @@ const smokeTests = [
   offlineOnlineOnly,
   offlineReady,
   offlineSwBroken,
-  offlineSwSlow,
   oopifRequests,
   oopifScripts,
   perfBudgets,

diff --git a/cli/test/smokehouse/test-definitions/offline-online-only.js b/cli/test/smokehouse/test-definitions/offline-online-only.js
@@ -13,7 +13,6 @@ const config = {
     ],
     onlyAudits: [
       'is-on-https',
-      'service-worker',
       'viewport',
       'user-timings',
       'critical-request-chains',
@@ -53,9 +52,6 @@ const expectations = {
       'paste-preventing-inputs': {
         score: 1,
       },
-      'service-worker': {
-        score: 0,
-      },
       'viewport': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/offline-ready.js b/cli/test/smokehouse/test-definitions/offline-ready.js
@@ -13,7 +13,6 @@ const config = {
     ],
     onlyAudits: [
       'is-on-https',
-      'service-worker',
       'viewport',
       'user-timings',
       'critical-request-chains',
@@ -70,13 +69,6 @@ const expectations = {
       'is-on-https': {
         score: 1,
       },
-      'service-worker': {
-        score: 1,
-        details: {
-          scriptUrl: 'http://localhost:10503/offline-ready-sw.js',
-          scopeUrl: 'http://localhost:10503/',
-        },
-      },
       'viewport': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/offline-sw-broken.js b/cli/test/smokehouse/test-definitions/offline-sw-broken.js
@@ -13,7 +13,6 @@ const config = {
     ],
     onlyAudits: [
       'is-on-https',
-      'service-worker',
       'viewport',
       'user-timings',
       'critical-request-chains',

diff --git a/cli/test/smokehouse/test-definitions/offline-sw-slow.js b/cli/test/smokehouse/test-definitions/offline-sw-slow.js
diff --git a/cli/test/smokehouse/test-definitions/pwa-airhorner.js b/cli/test/smokehouse/test-definitions/pwa-airhorner.js
@@ -23,9 +23,6 @@ const expectations = {
     requestedUrl: 'https://airhorner.com',
     finalDisplayedUrl: 'https://airhorner.com/',
     audits: {
-      'service-worker': {
-        score: 1,
-      },
       'viewport': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/pwa-caltrain.js b/cli/test/smokehouse/test-definitions/pwa-caltrain.js
@@ -23,9 +23,6 @@ const expectations = {
     requestedUrl: 'https://caltrainschedule.io/',
     finalDisplayedUrl: 'https://caltrainschedule.io/',
     audits: {
-      'service-worker': {
-        score: 1,
-      },
       'viewport': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/pwa-chromestatus.js b/cli/test/smokehouse/test-definitions/pwa-chromestatus.js
@@ -21,9 +21,6 @@ const expectations = {
     requestedUrl: 'https://chromestatus.com/features',
     finalDisplayedUrl: 'https://chromestatus.com/features',
     audits: {
-      'service-worker': {
-        score: 0,
-      },
       'viewport': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/pwa-rocks.js b/cli/test/smokehouse/test-definitions/pwa-rocks.js
@@ -27,9 +27,6 @@ const expectations = {
     requestedUrl: 'https://connorjclark.github.io/pwa.rocks/',
     finalDisplayedUrl: 'https://connorjclark.github.io/pwa.rocks/',
     audits: {
-      'service-worker': {
-        score: 1,
-      },
       'viewport': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/pwa-svgomg.js b/cli/test/smokehouse/test-definitions/pwa-svgomg.js
@@ -31,9 +31,6 @@ const expectations = {
     requestedUrl: 'https://jakearchibald.github.io/svgomg/',
     finalDisplayedUrl: 'https://jakearchibald.github.io/svgomg/',
     audits: {
-      'service-worker': {
-        score: 1,
-      },
       'viewport': {
         score: 1,
       },

diff --git a/core/audits/installable-manifest.js b/core/audits/installable-manifest.js
@@ -44,11 +44,6 @@ const UIStrings = {
   'manifest-display-not-supported': `Manifest 'display' property must be one of 'standalone', 'fullscreen', or 'minimal-ui'`,
   /** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
   'manifest-empty': `Manifest could not be fetched, is empty, or could not be parsed`,
-  // TODO: This error was removed in M114, we can remove this message when it hits stable.
-  /** Error message explaining that no matching service worker was detected,
-   * and provides a suggestion to reload the page or check whether the scope of the service worker
-   * for the current page encloses the scope and start URL from the manifest. */
-  'no-matching-service-worker': `No matching service worker detected. You may need to reload the page, or check that the scope of the service worker for the current page encloses the scope and start URL from the manifest.`,
   /**
    * @description Error message explaining that the manifest does not contain a suitable icon.
    * @example {192} value0
@@ -93,8 +88,8 @@ const UIStrings = {
   'manifest-location-changed': `Manifest URL changed while the manifest was being fetched.`,
   /** Warning message explaining that the page does not work offline. */
   'warn-not-offline-capable': `Page does not work offline. The page will not be regarded as installable after Chrome 93, stable release August 2021.`,
-  /** Error message explaining that Lighthouse failed while detecting a service worker, and directing the user to try again in a new Chrome. */
-  'protocol-timeout': `Lighthouse could not determine if there was a service worker. Please try with a newer version of Chrome.`,
+  /** Error message explaining that Lighthouse failed while checking if the page is installable, and directing the user to try again in a new Chrome. */
+  'protocol-timeout': `Lighthouse could not determine if the page is installable. Please try with a newer version of Chrome.`,
   /** Message logged when the web app has been uninstalled o desktop, signalling that the install banner state is being reset. */
   'pipeline-restarted': 'PWA has been uninstalled and installability checks resetting.',
   /**

diff --git a/core/audits/service-worker.js b/core/audits/service-worker.js
diff --git a/core/config/default-config.js b/core/config/default-config.js
@@ -176,7 +176,6 @@ const defaultConfig = {
   ],
   audits: [
     'is-on-https',
-    'service-worker',
     'viewport',
     'metrics/first-contentful-paint',
     'metrics/largest-contentful-paint',
@@ -638,7 +637,6 @@ const defaultConfig = {
         // Installable
         {id: 'installable-manifest', weight: 2, group: 'pwa-installable'},
         // PWA Optimized
-        {id: 'service-worker', weight: 1, group: 'pwa-optimized'},
         {id: 'splash-screen', weight: 1, group: 'pwa-optimized'},
         {id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
         {id: 'content-width', weight: 1, group: 'pwa-optimized'},