refactor typing

GoogleChrome · Jul 6, 2023 · e52106a · e52106a
1 parent 315a9f7
commit e52106a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/core/computed/metrics/cumulative-layout-shift.js b/core/computed/metrics/cumulative-layout-shift.js
@@ -133,7 +133,8 @@ class CumulativeLayoutShift {
         return allFrameShiftEvents.some(lse => lse.event === event);
       });
       await processor.parse(filteredTrace);
-      const data = /** @type {{LayoutShifts: {sessionMaxScore: number}}} */ (processor.data);
+      const data = /** @type {import('../../lib/cdt/SDK.js').TraceProcessorResult} */ (
+        processor.data);
       cumulativeLayoutShift = data.LayoutShifts.sessionMaxScore;
     } catch (e) {
       // Something failed, so fallback to our own implementation.

diff --git a/core/lib/cdt/SDK.js b/core/lib/cdt/SDK.js
@@ -10,6 +10,9 @@ const SDK = {
   TraceHandlers: require('./generated/models/trace/handlers/handlers.js').ModelHandlers,
 };
 
+/** @typedef {{sessionMaxScore: number}} LayoutShiftsHandler */
+/** @typedef {{LayoutShifts: LayoutShiftsHandler}} TraceProcessorResult */
+
 // Add `lastColumnNumber` to mappings. This will eventually be added to CDT.
 // @ts-expect-error
 SDK.SourceMap.prototype.computeLastGeneratedColumns = function() {