Skip to content

Commit

Permalink
Merge branch 'main' into remove-legacy-smoke
Browse files Browse the repository at this point in the history
  • Loading branch information
adamraine authored Jul 11, 2023
2 parents edcac4e + 2bd5e7e commit a834b45
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
5 changes: 1 addition & 4 deletions third-party/devtools-tests/e2e/lighthouse/navigation_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import {
setLegacyNavigation,
setThrottlingMethod,
setToolbarCheckboxWithText,
unregisterAllServiceWorkers,
waitForResult,
} from '../helpers/lighthouse-helpers.js';

Expand Down Expand Up @@ -62,9 +61,7 @@ describe('Navigation', async function() {
});

afterEach(async function() {
await unregisterAllServiceWorkers();

const {frontend} = await getBrowserAndPages();
const {frontend} = getBrowserAndPages();
frontend.off('console', consoleListener);

if (this.currentTest?.isFailed()) {
Expand Down
5 changes: 0 additions & 5 deletions third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
navigateToLighthouseTab,
registerServiceWorker,
selectMode,
unregisterAllServiceWorkers,
waitForResult,
} from '../helpers/lighthouse-helpers.js';

Expand All @@ -39,10 +38,6 @@ describe('Snapshot', async function() {
expectError(/Protocol Error: the message with wrong session id/);
});

afterEach(async () => {
await unregisterAllServiceWorkers();
});

it('successfully returns a Lighthouse report for the page state', async () => {
await navigateToLighthouseTab('lighthouse/hello.html');
await registerServiceWorker();
Expand Down
5 changes: 0 additions & 5 deletions third-party/devtools-tests/e2e/lighthouse/timespan_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
selectDevice,
selectMode,
setThrottlingMethod,
unregisterAllServiceWorkers,
waitForResult,
waitForTimespanStarted,
} from '../helpers/lighthouse-helpers.js';
Expand All @@ -43,10 +42,6 @@ describe('Timespan', async function() {
expectError(/Protocol Error: the message with wrong session id/);
});

afterEach(async () => {
await unregisterAllServiceWorkers();
});

it('successfully returns a Lighthouse report for user interactions', async () => {
await navigateToLighthouseTab('lighthouse/hello.html');
await registerServiceWorker();
Expand Down

0 comments on commit a834b45

Please sign in to comment.