Merge branch 'main' into rm-pwa

GoogleChrome · Apr 2, 2024 · 7e05549 · 7e05549
2 parents 68e9879 + 7801bc4
commit 7e05549
Show file tree

Hide file tree

Showing 82 changed files with 379 additions and 3,902 deletions.
diff --git a/cli/test/fixtures/a11y/a11y_tester.html b/cli/test/fixtures/a11y/a11y_tester.html
@@ -142,11 +142,6 @@
         <dd></dd>
       </div>
     </section>
-    <p>duplicate-id-active</p>
-    <section>
-      <textarea id="duplicate-id-active" aria-label="text1"></textarea>
-      <textarea id="duplicate-id-active" aria-label="text2"></textarea>
-    </section>
     <p>duplicate-id-aria</p>
     <section>
       <div id="duplicate-id-aria" class="duplicate-id-aria"></span>

diff --git a/cli/test/fixtures/dobetterweb/dbw_tester.html b/cli/test/fixtures/dobetterweb/dbw_tester.html
@@ -242,16 +242,6 @@ <h2 id="toppy" style="background-image:url('');">Do better web tester page</h2>
 <!-- FAIL(efficient-animated-content): animated gif found -->
 <img src="lighthouse-rotating.gif" width="811" height="462">
 
-<!-- FAIL(tap-targets): buttons too close together -->
-<style>
-.small-button {
-  display: block;
-  width: 200px;
-}
-</style>
-<button class="small-button">Do something</button>
-<button class="small-button">Do something else</button>
-
 <!-- Some websites overwrite the original Error object. The captureJSCallUsage function
   relies on the native Error object and prepareStackTrace from V8. When overwriting the stack
   property the e.stack inside the gatherer won't be in the correct format

diff --git a/cli/test/fixtures/seo/seo-tap-targets.html b/cli/test/fixtures/seo/seo-tap-targets.html
diff --git a/cli/test/fixtures/static-server.js b/cli/test/fixtures/static-server.js
@@ -109,6 +109,12 @@ class Server {
         'Origin-Agent-Cluster': '?1',
       };
 
+      // This enables an important test in Smokerider - to check if the universal fetcher
+      // used for robots.txt (and source maps) is able to fetch freely while ignoring CORS constraints.
+      if (filePath === '/robots.txt') {
+        delete headers['Access-Control-Allow-Origin'];
+      }
+
       const contentType = mime.lookup(filePath);
       const charset = mime.lookup(contentType);
       // `mime.contentType` appends the correct charset too.

diff --git a/cli/test/smokehouse/core-tests.js b/cli/test/smokehouse/core-tests.js
@@ -56,7 +56,6 @@ import screenshot from './test-definitions/screenshot.js';
 import seoFailing from './test-definitions/seo-failing.js';
 import seoPassing from './test-definitions/seo-passing.js';
 import seoStatus403 from './test-definitions/seo-status-403.js';
-import seoTapTargets from './test-definitions/seo-tap-targets.js';
 import serviceWorkerReloaded from './test-definitions/service-worker-reloaded.js';
 import shiftAttribution from './test-definitions/shift-attribution.js';
 import sourceMaps from './test-definitions/source-maps.js';
@@ -116,7 +115,6 @@ const smokeTests = [
   seoFailing,
   seoPassing,
   seoStatus403,
-  seoTapTargets,
   serviceWorkerReloaded,
   shiftAttribution,
   sourceMaps,