Skip to content

Commit

Permalink
misc: do not double report artifact dep error to sentry (#15777)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored Jan 26, 2024
1 parent b4573d0 commit 5e18c5a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion core/gather/runner-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ import {Sentry} from '../lib/sentry.js';
* @param {Error} error
*/
function createDependencyError(dependency, error) {
return new Error(`Dependency "${dependency.id}" failed with exception: ${error.message}`);
const err = new Error(`Dependency "${dependency.id}" failed with exception: ${error.message}`);
// @ts-expect-error - We already reported the original error to Sentry, don't do it again.
err.expected = true;
return err;
}

/** @return {ArtifactState} */
Expand Down

1 comment on commit 5e18c5a

@vercel
Copy link

@vercel vercel bot commented on 5e18c5a Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

lighthouse – ./

lighthouse-git-main-googlechrome.vercel.app
lighthouse-googlechrome.vercel.app

Please sign in to comment.