Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Aside code cleanup #6061

Conversation

ShayPunter
Copy link
Collaborator

@ShayPunter ShayPunter commented Apr 20, 2023

Fixes GoogleChrome/webdev-infra#77

Changes proposed in this pull request:

  • Migrates the aside component to webdev-infra
  • A clean up of the now unused aside files in d.c.c.
  • Updated handbook components documentation to include tip aside, objective aside & celebration aside

@google-cla
Copy link

google-cla bot commented Apr 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chrome-devrel-infra
Copy link

chrome-devrel-infra bot commented Apr 20, 2023

❌ Failed to build (static) the site for commit c44392d. Building the site (npm run production) failed with the following error output:

[14:24:39] 'sass' errored after 422 ms
[14:24:39] Error: Can't find stylesheet to import.
   ╷
16 │ @import 'node_modules/webdev-infra/shortcodes/Aside/styles';
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
  site/_scss/main.scss 16:9  root stylesheet
    at Object._newRenderError (/workspace/node_modules/sass/sass.dart.js:13478:19)
    at Object._wrapException (/workspace/node_modules/sass/sass.dart.js:13321:16)
    at StaticClosure._renderSync (/workspace/node_modules/sass/sass.dart.js:13296:18)
    at Object.Primitives_applyFunction (/workspace/node_modules/sass/sass.dart.js:1085:30)
    at Object.Function_apply (/workspace/node_modules/sass/sass.dart.js:6003:16)
    at _callDartFunctionFast (/workspace/node_modules/sass/sass.dart.js:7672:16)
    at Object.renderSync (/workspace/node_modules/sass/sass.dart.js:7650:18)
    at /workspace/gulp-tasks/sass.js:32:34
    at Array.forEach (<anonymous>)
    at sass (/workspace/gulp-tasks/sass.js:31:15)
[14:24:39] 'default' errored after 430 ms
ERROR: "gulp" exited with 1.

Check the Stage (dcc-staging) check status for more details.

@ShayPunter ShayPunter force-pushed the 77_migrate_and_consolidate_aside_implementations_in_webdev-infra, branch from c340940 to 30423b6 Compare April 20, 2023 10:16
Copy link
Collaborator

@jimjiminyjimjim jimjiminyjimjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShayPunter ShayPunter marked this pull request as ready for review April 24, 2023 09:32
@ShayPunter ShayPunter marked this pull request as draft May 10, 2023 14:22
@matthiasrohmer
Copy link
Collaborator

Won't fix, due to the pending move to the new CMS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate and consolidate aside implementations in webdev-infra, implement Tip type
3 participants