Skip to content

Commit

Permalink
Don't ignore change requests when the blocking user is requested to r…
Browse files Browse the repository at this point in the history
…eview (#105)

It's fine to remove approvals by requesting reviews but we shouldn't remove change requests by requesting reviews

Signed-off-by: Yarden Shoham <[email protected]>
  • Loading branch information
yardenshoham authored Sep 1, 2023
1 parent dfe4f56 commit cd9cf57
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,9 @@ export const getPrReviewers = async (
}
}

// any requested reviewers are not approvers nor blockers
// any requested reviewers are not approvers
for (const requestedReviewer of pr.requested_reviewers) {
approvers.delete(requestedReviewer.login);
blockers.delete(requestedReviewer.login);
}

return { approvers, blockers };
Expand Down

0 comments on commit cd9cf57

Please sign in to comment.