Add PolylinesOverlap function #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickackermann
requested changes
Dec 19, 2023
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public final class PolylinesNotOverlappingIoxPluginTest { |
There was a problem hiding this comment.
Q: Wie ist das Verhalten bei zwei identischen Linien, wird das getestet?
There was a problem hiding this comment.
Ich habe das Verhalten noch etwas angepasst, dass Linien mit gleichen Teilstrecken nun auch als Overlap gelten (es entspricht somit nicht mehr zu 100% der Definition von overlap, aber ich habe keinen passenderen Begriff gefunden).
Dabei wird geprüft, dass die Schnittmenge der Linien ebenfalls eine Linie ist (entspricht den Beispielen 29-47 im folgenden Bild).
...java/ch/geowerkstatt/ilivalidator/extensions/functions/PolylinesNotOverlappingIoxPlugin.java
Outdated
Show resolved
Hide resolved
domi-b
changed the title
domi-b
commented
Dec 20, 2023
src/main/java/ch/geowerkstatt/ilivalidator/extensions/functions/PolylinesOverlapIoxPlugin.java
Show resolved
Hide resolved
patrickackermann
requested changes
Dec 20, 2023
src/main/java/ch/geowerkstatt/ilivalidator/extensions/functions/PolylinesOverlapIoxPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/geowerkstatt/ilivalidator/extensions/functions/PolylinesOverlapIoxPlugin.java
Show resolved
Hide resolved
src/main/java/ch/geowerkstatt/ilivalidator/extensions/functions/PolylinesOverlapIoxPlugin.java
Outdated
Show resolved
Hide resolved
patrickackermann
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32