Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter null identifiers #106

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: filter null identifiers #106

merged 1 commit into from
Aug 28, 2024

Conversation

admy7
Copy link
Contributor

@admy7 admy7 commented Aug 28, 2024

Summary by Sourcery

Fix the issue of null identifiers being included in the list of dataset IDs by adding a filter to remove null values.

Bug Fixes:

  • Filter out null identifiers from the list of dataset IDs collected from CKAN packages.

@admy7 admy7 self-assigned this Aug 28, 2024
Copy link

sourcery-ai bot commented Aug 28, 2024

Reviewer's Guide by Sourcery

This pull request addresses a potential issue with null identifiers in the dataset collection process. The change adds a filter to remove null identifiers from the stream of CkanPackage objects before converting them to a list.

File-Level Changes

Change Details Files
Added null check filter in dataset identifier collection
  • Inserted a filter step in the stream pipeline to remove null identifiers
  • Used Objects::nonNull as the predicate for the filter operation
src/main/java/io/github/genomicdatainfrastructure/discovery/datasets/infrastructure/ckan/persistence/CkanDatasetIdsCollector.java

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @admy7 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@admy7 admy7 merged commit 7cf34d6 into main Aug 28, 2024
3 checks passed
@nolliia nolliia deleted the filter-null-identifiers branch August 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants