Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): remove Keycloak integration from CKAN and user portal #93

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

hcvdwerf
Copy link
Contributor

@hcvdwerf hcvdwerf commented Sep 13, 2024

  • Disabled Keycloak in user portal extension

Summary by Sourcery

Remove Keycloak integration from the CKAN user portal by updating the login link to use the default user login route instead of the OIDC PKCE route.

- Disabled Keycloak in user portal extension
Copy link
Contributor

sourcery-ai bot commented Sep 13, 2024

Reviewer's Guide by Sourcery

This pull request removes the Keycloak integration from CKAN and the user portal. The main change is in the header template, where the login link is modified to use the standard CKAN login route instead of the Keycloak-specific OIDC route.

File-Level Changes

Change Details Files
Modified login link in header template to remove Keycloak integration
  • Replaced OIDC-PKCE login route with standard CKAN login route
  • Updated the login icon from 'fa-sign-in' to 'fa-sign'
  • Restructured the HTML for better readability
ckanext/gdi_userportal/templates/header.html

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hcvdwerf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more context about why Keycloak is being removed? It would be helpful to understand the reasoning behind this architectural change.
  • What is the authentication strategy going forward? Is there a replacement for Keycloak, or are you reverting to CKAN's default authentication?
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

ckanext/gdi_userportal/templates/header.html Outdated Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Copy link

sonarcloud bot commented Sep 16, 2024

@brunopacheco1 brunopacheco1 merged commit bca777f into main Sep 16, 2024
2 checks passed
@brunopacheco1 brunopacheco1 deleted the remove-keycloak-login branch September 16, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants