Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdi 95 add typing and comments in the fdp gdi repo #5

Merged

Conversation

a-nayden
Copy link

@a-nayden a-nayden commented Jan 24, 2024

  • type hints added
  • logging for other that 200 FDP response
  • fix parse None issue and tests accordingly
  • use rdflib namespaces instead of hard-coded predicates

@brunopacheco1
Copy link
Collaborator

@a-nayden excelent PR, thanks a lot for all those changes.

@kburger kburger self-requested a review January 25, 2024 08:03
Copy link

@kburger kburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great improvement. There are some minor things to be gained, like fstrings vs .format and shorthand requests calls, but that's for later.

@brunopacheco1 brunopacheco1 merged commit 25ea735 into user-portal Jan 25, 2024
2 checks passed
@hcvdwerf hcvdwerf deleted the GDI-95-add-typing-and-comments-in-the-fdp-gdi-repo branch February 15, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants