Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Harvester] parse iso8601 compliant timestamps #14

Merged

Conversation

a-nayden
Copy link

fix time format: CKAN could not convert timesharing to date time if timezone is in the timestring
add tags validation: characters other than alphanumeric, dots, spaces, hyphens and underscores are replaced with spaces.
comment out example adding hello field to each dataset

brunopacheco1
brunopacheco1 previously approved these changes Mar 18, 2024
Copy link
Collaborator

@brunopacheco1 brunopacheco1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: You could also add tests for validate_tags.

@a-nayden
Copy link
Author

suggestion: You could also add tests for validate_tags.

done

@brunopacheco1 brunopacheco1 merged commit 49907b6 into user-portal Mar 18, 2024
2 checks passed
@brunopacheco1 brunopacheco1 deleted the harvester]-parse-iso8601-compliant-timestamps branch March 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants