feat: Only submit applications that are in draft or returned status #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmiPali
previously approved these changes
Mar 21, 2024
brunopacheco1
requested changes
Mar 21, 2024
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Show resolved
Hide resolved
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Outdated
Show resolved
Hide resolved
...ava/io/github/genomicdatainfrastructure/daam/mappers/ApplicationNotFoundExceptionMapper.java
Outdated
Show resolved
Hide resolved
...ava/io/github/genomicdatainfrastructure/daam/mappers/ApplicationNotFoundExceptionMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Show resolved
Hide resolved
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Show resolved
Hide resolved
.../github/genomicdatainfrastructure/daam/exceptions/ApplicationNotInCorrectStateException.java
Outdated
Show resolved
Hide resolved
...main/java/io/github/genomicdatainfrastructure/daam/exceptions/UserNotApplicantException.java
Outdated
Show resolved
Hide resolved
...n/java/io/github/genomicdatainfrastructure/daam/exceptions/ApplicationNotFoundException.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Outdated
Show resolved
Hide resolved
...thub/genomicdatainfrastructure/daam/mappers/ApplicationNotInCorrectStateExceptionMapper.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 21, 2024 14:39
.../github/genomicdatainfrastructure/daam/exceptions/ApplicationNotInCorrectStateException.java
Outdated
Show resolved
Hide resolved
brunopacheco1
previously approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Hey @inderps thanks a lot for you pacience and for promptly improving the code.
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/genomicdatainfrastructure/daam/services/SubmitApplicationService.java
Outdated
Show resolved
Hide resolved
...ava/io/github/genomicdatainfrastructure/daam/mappers/ApplicationNotFoundExceptionMapper.java
Outdated
Show resolved
Hide resolved
src/test/java/io/github/genomicdatainfrastructure/daam/api/ApplicationCommandApiImplTest.java
Show resolved
Hide resolved
|
brunopacheco1
approved these changes
Mar 22, 2024
brunopacheco1
deleted the
issue-5/only-submit-draft-and-returned-applications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.