-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support options and tables #131
Conversation
Reviewer's Guide by SourceryThis pull request enhances the RemsApplicationMapper class to support additional features such as options and tables. It also updates the OpenAPI specifications for both REMS and DAAM, and modifies the SaveDraftCommandMapper to handle table values. The changes primarily focus on improving the mapping of form fields and their associated data structures. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brunopacheco1 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
src/main/java/io/github/genomicdatainfrastructure/daam/gateways/SaveDraftCommandMapper.java
Show resolved
Hide resolved
src/test/java/io/github/genomicdatainfrastructure/daam/gateways/RemsApplicationMapperTest.java
Show resolved
Hide resolved
src/test/java/io/github/genomicdatainfrastructure/daam/gateways/RemsApplicationMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/github/genomicdatainfrastructure/daam/gateways/RemsApplicationMapperTest.java
Show resolved
Hide resolved
dbf55ad
to
0a6e272
Compare
0a6e272
to
d682004
Compare
Summary by Sourcery
Enhance the form field processing capabilities by adding support for table values and additional attributes such as privacy, options, and columns. Refactor the
RemsApplicationMapper
to improve code structure and update the OpenAPI specifications to reflect these changes. Adjust tests to ensure coverage of new features and enhancements.New Features:
Enhancements:
RemsApplicationMapper
to use a builder pattern for creatingRetrievedApplicationFormField
andRetrievedApplicationEvent
objects, improving code readability and maintainability.RemsApplicationMapper
to handle privacy, options, and columns for form fields, enhancing the flexibility of form data processing.Documentation:
infoText
,maxLength
,privacy
,options
, andtableColumns
, providing a more comprehensive API documentation.Tests:
RemsApplicationMapperTest
to accommodate changes in theRemsApplicationMapper
class, ensuring that new features and enhancements are properly tested.