Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

never add core_theme to THEMES #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

never add core_theme to THEMES #291

wants to merge 1 commit into from

Conversation

hhaensel
Copy link
Member

Currently, when theme() is called once, the coretheme is added to THEMES[].

This is a bit unfortunate, because you first have to remove it manually if you want to render a page without core_theme. Moreover, parallel pages with and without core_theme are difficult to maintain. As theme() is anyhow called in order to append all stylesheets to the page, we can rely on the keyword attribute. Currently it's always added and then removed by unique!() if it was present before. Moreover, I made it a named function make it more understandable.

@hhaensel hhaensel marked this pull request as ready for review October 10, 2024 17:24
@hhaensel
Copy link
Member Author

Maybe we should push the coretheme before all other themes so that the user can overwrite it. And we could name the function stipplecore() instead of coretheme()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant