Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass OverlayState for showing the fullscreen player #282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SEGVeenstra
Copy link

This PR adds the overlay parameter to FlickVideoPlayer so you can provide an OverlayState that will be used to show the fullscreen player.

This resolves the issue where the fullscreen player only covers a portion of the screen if you are using nested navigators for example.

FlickVideoPlayer(
  flickManager: _manager!,
  overlay: Navigator.of(context, rootNavigator: true).overlay,
),

Small

Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 14 44 58

Fullscreen without passing overlay

The bottom navigation remains visible
Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 14 45 38

Fullscreen with passing overlay

Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 14 45 18

@SEGVeenstra SEGVeenstra marked this pull request as ready for review July 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants