Fix/report bug #134
Merged
Fix/report bug #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/report_bug
…ade/output/output.py.
…into fix/report_bug
…de/output/output.py.
…rts in gatorgrade/output/output.py.
… gatorgrade/output/output.py.
…rade/output/output.py.
…n gatorgrade/input/in_file_path.py.
…tput/check_result.py file.
…ut/command_line_generator.py file.
…t all functions have type annotations.
…ave correct character encoding.
…github/workflows/main.yml.
…ut/output.py so it only writes to GITHUB_ENV when it is set.
…t exist in gatorgrade/output/output.py.
|
@rebekahrudd I think that this PR resolves all of the issues that we discussed on Thursday and Friday of this week. Due to the fact that I am facing severe time constraints in light of upcoming travel, I am going to merge the PR and make a new release to PyPI and then invite other members of our team to test it further. I will also test it through some existing assignments and confirm that everything works in GitHub Actions and that the new diagnostic messages are also output when run either in GitHub Actions or in the terminal window on a laptop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative Fix for the Report Generation Defect
Description
Aims to give the problems with (i) the build failing and (ii) defective release to PyPI. The main problem is that the command
gatorgrade --report env md GITHUB_STEP_SUMMARYseems to crash when it is run in GitHub Actions with this feature. This PR also resolves several defects where, for instance,gatorgradewill crash when it is run on a laptop with the aforementioned command --- even though that command will, in fact, work correctly when it is run in GitHub Actions. It is also important to note that this PR moves this project over to the use ofruffand stops the use of other tools likepylint. Finally, the PR removes one or two test cases that were flaky and no longer running predictably.Type of Change
Contributors
Reminder
Notes
This is currently a draft PR so that others can see the progress that @rebekahrudd is making and to then give feedback and try it out and to suggest additional fixes as needed. Thanks!