This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Use the executable created by linuxgsm #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neo-Desktop
suggested changes
Oct 8, 2022
Comment on lines
+39
to
+42
| exec_name=$(./linuxgsm.sh ${GAMESERVER} | grep -o ${GAMESERVER}-. | head -1) | ||
| if [ ! -z "$exec_name" ]; then | ||
| export GAMESERVER=$exec_name | ||
| fi |
There was a problem hiding this comment.
I think a better way of doing this would be using a bash parameter expansion substring
A REPL for this is available here
Suggested change
| exec_name=$(./linuxgsm.sh ${GAMESERVER} | grep -o ${GAMESERVER}-. | head -1) | |
| if [ ! -z "$exec_name" ]; then | |
| export GAMESERVER=$exec_name | |
| fi | |
| ./linuxgsm.sh ${GAMESERVER%-*} |
There was a problem hiding this comment.
you may need to alter other parts of the script as well (such as exit_handler())
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the linuxgsm creates the game server executable file, the entrypoint is assuming $GAMESERVER is the name of the exec.
Or if the exec has been created before but is not executable (by the touch command) the linuxgsm will install a new instance (which have "-2" added to its name) but the script doesn't use this new name.
So I just did a grep to get the new file name, and then replace the GAMESERVER env variable. This new value is then used to install, update and start the server.