Feature/maroon 404 falling ball viscosimeter #511
Conversation
not working :(
…//github.com/GameLabGraz/Maroon into feature/Maroon-404_Falling_Ball_Viscosimeter
- Ball und Röhre bewegt, damit es besser in schirm passt - Pyknometer leergewicht bug behoben - Hahn für Pyknometer - Messmodus verbessert - UI Elemente auf die notwendigen reduziert - Ball Startgröße vergrößert
…rag when measuring.
…//github.com/GameLabGraz/Maroon into feature/Maroon-404_Falling_Ball_Viscosimeter
Moved Fluid property calculation to ViscosimeterManager
- Make Reset Ball more clear - Make it more clear that slow motion is active. - Hint for zooming during measurements. - Change key binding to mouse2 for panning in zoom mode - disable collider of measured object - Do not reset temperature after resetting the simulation. Added bool for allowing reset in the QuantityPropertyView
There was a problem hiding this comment.
The experiment is really cool, and very well done! I think it is really well-suited to conduct experiments with it and actually learn about viscosity. 😄
I made a lot of remarks but mostly about code formatting, naming of methods, missing namespaces etc., so the vast majority of comments will not take up lots of time.
Please also merge with develop branch.
But again: very cool experiment! 👍
There was a problem hiding this comment.
If VR is not supported for the experiment, please delete the scene
There was a problem hiding this comment.
Incorrect text in laboratory
(missing translation in Assets/Resources/MLG/laboratory.xml probably)
There was a problem hiding this comment.
Colliders are too large / too many colliders
(only the table and info stand sign thing should have colliders)
There was a problem hiding this comment.
Please delete unnecessary Coulombs Law stuff from this experiment
| //calculate dynamic viscosity | ||
| decimal dynamic_viscosity = ViscosimeterManager.Instance.calculateDynamicViscosity(temperature); | ||
|
|
||
| Debug.Log("dynamic visc " + dynamic_viscosity); |
There was a problem hiding this comment.
please remove this Debug.Log
There was a problem hiding this comment.
When using any fluid other than 1,2-Ethanediol, (e.g. Cyclohexane), then the ball jumps up and down at the bottom of the cylinder tube
There was a problem hiding this comment.
not too big of a deal i suppose, but when the ball rotates, the ball camera rotates as well
There was a problem hiding this comment.
When placing the ball, I often placed it to the Faucet snap point by accident
Then the ball was outside the tube, but it still behaved (falling speed) the same as inside the tube filled with fluid
if it's not too much work it would be cool to prevent the ball from snapping to this snap point
There was a problem hiding this comment.
Is it on purpose that the tooltip for the tube only appears above and below the red lines? (not in the center)
There was a problem hiding this comment.
When clicking Measure Length and then on e.g. the tube, I get the following error
Close #404