989 add fixed step plugin #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RiscadoA
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Thanks for working on this! Some points to take care of before merging:
- you included two commits with the same desc, please merge them.
- rename the plugin dir to
fixed_stepto follow the naming convention of other plugins. - don't forget to add the change to the change log :)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 36.15% 36.18% +0.02%
==========================================
Files 297 298 +1
Lines 24411 24396 -15
==========================================
Hits 8827 8827
+ Misses 15584 15569 -15 ☔ View full report in Codecov by Sentry. |
joaomanita
force-pushed
the
989-add-fixed-step-plugin
branch
from
d22d197
to
184a2fd
Compare
joaomanita
force-pushed
the
989-add-fixed-step-plugin
branch
from
184a2fd
to
1b7809c
Compare
RiscadoA
requested changes
Feb 21, 2024
joaomanita
force-pushed
the
989-add-fixed-step-plugin
branch
from
1b7809c
to
5727aad
Compare
RiscadoA
requested changes
Feb 21, 2024
joaomanita
force-pushed
the
989-add-fixed-step-plugin
branch
from
5727aad
to
972d6e2
Compare
RiscadoA
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added fixedStepPlugin which creates the cubos.fixedStep Tag, any systems with that tag will
run at 100 fps.
Checklist