Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PhysicsBundle component when finished unpacking #982

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

fallenatlas
Copy link
Contributor

Description

I forgot to put this.

@fallenatlas fallenatlas self-assigned this Feb 17, 2024
Copy link
Contributor

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-982/
on branch gh-pages at 2024-02-17 13:00 UTC

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b342eb5) 36.13% compared to head (235ec9e) 36.13%.

Files Patch % Lines
engine/src/physics/plugin.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   36.13%   36.13%   -0.01%     
==========================================
  Files         297      297              
  Lines       24397    24398       +1     
==========================================
  Hits         8817     8817              
- Misses      15580    15581       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallenatlas fallenatlas merged commit 70ab51b into main Feb 17, 2024
11 checks passed
@fallenatlas fallenatlas deleted the remove-physics-bundle-on-unpack branch February 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants