Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

950 add functionality to make debugcamera and freecameracontroller to coexist in tesseratos #952

Merged
merged 3 commits into from
Feb 11, 2024
Merged

950 add functionality to make debugcamera and freecameracontroller to coexist in tesseratos #952

merged 3 commits into from
Feb 11, 2024

Conversation

diogomsmiranda
Copy link
Contributor

Write a functionality to disable and enable FCC on DebugCamera

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@diogomsmiranda diogomsmiranda linked an issue Feb 6, 2024 that may be closed by this pull request
Add functionality to make DebugCamera and FreeCameraController to coexist in Tesseratos #950
Closed
@github-actions github-actions bot added A-Tesseratos S-Triage Issues whose priority still has to be figured out labels Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-952/
on branch gh-pages at 2024-02-11 14:38 UTC

github-actions[bot]
github-actions bot previously requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/utils/free_camera_controller/plugin.cpp Outdated Show resolved Hide resolved
engine/src/utils/free_camera_controller/plugin.cpp Outdated Show resolved Hide resolved
engine/src/utils/free_camera_controller/plugin.cpp Outdated Show resolved Hide resolved
engine/src/utils/free_camera_controller/plugin.cpp Outdated Show resolved Hide resolved
engine/src/utils/free_camera_controller/plugin.cpp Outdated Show resolved Hide resolved
engine/src/utils/free_camera_controller/plugin.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review February 6, 2024 20:54

No Clang-Tidy warnings found so I assume my comments were addressed

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (d70d953) 35.88% compared to head (ab6eaf4) 35.93%.

Files Patch % Lines
engine/src/utils/free_camera/plugin.cpp 0.00% 29 Missing ⚠️
engine/src/utils/free_camera/controller.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
+ Coverage   35.88%   35.93%   +0.04%     
==========================================
  Files         292      292              
  Lines       24080    24052      -28     
==========================================
  Hits         8642     8642              
+ Misses      15438    15410      -28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DiogoMendonc-a
Copy link
Contributor

Dá resolve às conversations do bot que já tiveres resolvido

DiogoMendonc-a
DiogoMendonc-a requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@DiogoMendonc-a DiogoMendonc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working, I think the binding is not being defined,

tools/tesseratos/src/tesseratos/debug_camera/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/debug_camera/plugin.cpp Outdated Show resolved Hide resolved
@diogomsmiranda diogomsmiranda force-pushed the 950-add-functionality-to-make-debugcamera-and-freecameracontroller-to-coexist-in-tesseras branch from 92d57ff to 0612d99 Compare February 7, 2024 15:42
@diogomsmiranda diogomsmiranda changed the title 950 add functionality to make debugcamera and freecameracontroller to coexist in tessera's 950 add functionality to make debugcamera and freecameracontroller to coexist in tesseratos Feb 7, 2024
@diogomsmiranda diogomsmiranda force-pushed the 950-add-functionality-to-make-debugcamera-and-freecameracontroller-to-coexist-in-tesseras branch from 0612d99 to ef5ef92 Compare February 10, 2024 15:16
@diogomsmiranda diogomsmiranda force-pushed the 950-add-functionality-to-make-debugcamera-and-freecameracontroller-to-coexist-in-tesseras branch 2 times, most recently from b253358 to 0612d99 Compare February 10, 2024 15:37
@diogomsmiranda diogomsmiranda self-assigned this Feb 10, 2024
github-actions[bot]
github-actions bot previously requested changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tools/tesseratos/samples/main/main.cpp Show resolved Hide resolved
tools/tesseratos/samples/main/main.cpp Show resolved Hide resolved
tools/tesseratos/samples/main/main.cpp Show resolved Hide resolved
tools/tesseratos/samples/main/main.cpp Show resolved Hide resolved
@diogomsmiranda diogomsmiranda force-pushed the 950-add-functionality-to-make-debugcamera-and-freecameracontroller-to-coexist-in-tesseras branch 2 times, most recently from d27ad12 to 969610d Compare February 10, 2024 20:12
@github-actions github-actions bot dismissed their stale review February 10, 2024 20:13

No Clang-Tidy warnings found so I assume my comments were addressed

@RiscadoA RiscadoA force-pushed the 950-add-functionality-to-make-debugcamera-and-freecameracontroller-to-coexist-in-tesseras branch from 969610d to ab6eaf4 Compare February 11, 2024 14:37
@RiscadoA RiscadoA merged commit dc686ce into main Feb 11, 2024
11 checks passed
@RiscadoA RiscadoA deleted the 950-add-functionality-to-make-debugcamera-and-freecameracontroller-to-coexist-in-tesseras branch February 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoMendonc-a DiogoMendonc-a DiogoMendonc-a requested changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@roby2014 roby2014 Awaiting requested review from roby2014

@RiscadoA RiscadoA Awaiting requested review from RiscadoA RiscadoA is a code owner

@fallenatlas fallenatlas Awaiting requested review from fallenatlas

Assignees

@diogomsmiranda diogomsmiranda

Labels
A-Tesseratos S-Triage Issues whose priority still has to be figured out
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality to make DebugCamera and FreeCameraController to coexist in Tesseratos
3 participants
@diogomsmiranda @DiogoMendonc-a @RiscadoA