Implement save for scenebridge #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiogoMendonc-a
force-pushed
the
352-implement-save-for-scenebridge
branch
from
95628c3
to
f0b525f
Compare
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
- Coverage 35.38% 35.36% -0.02%
==========================================
Files 287 289 +2
Lines 23872 24022 +150
==========================================
+ Hits 8447 8496 +49
- Misses 15425 15526 +101 ☔ View full report in Codecov by Sentry. |
github-actions
bot
dismissed stale reviews from themself
No Clang-Tidy warnings found so I assume my comments were addressed
RiscadoA
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Thanks for working on this! Overall LGTM, will approve, but make sure to resolve the comments I wrote before merging. Also: regarding the blueprint realation serialization change (to use '@'), make sure that docs match the new format. IIRC i wrote some stuff explaining the previous format, not sure where (perhaps in the bridge docs or sample)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the changes here.
Checklist