Box to Box Collisions #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 36.00% 35.83% -0.17%
==========================================
Files 293 296 +3
Lines 24079 24192 +113
==========================================
Hits 8669 8669
- Misses 15410 15523 +113 ☔ View full report in Codecov by Sentry. |
RiscadoA
reviewed
Feb 2, 2024
fallenatlas
force-pushed
the
524-box-to-box-collisions
branch
from
96c7f77
to
cb165f5
Compare
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fallenatlas
force-pushed
the
524-box-to-box-collisions
branch
from
92e8909
to
6a471f4
Compare
fallenatlas
force-pushed
the
524-box-to-box-collisions
branch
from
120c02c
to
676c498
Compare
github-actions
bot
dismissed stale reviews from themself
No Clang-Tidy warnings found so I assume my comments were addressed
fallenatlas
force-pushed
the
524-box-to-box-collisions
branch
2 times, most recently
from
a1f3d40
to
6a458ee
Compare
RiscadoA
requested changes
Feb 9, 2024
engine/include/cubos/engine/collisions/narrow_phase/colliding_with.hpp
Outdated
Show resolved
Hide resolved
RiscadoA
approved these changes
Feb 12, 2024
fallenatlas
force-pushed
the
524-box-to-box-collisions
branch
from
11848a5
to
ef1f98f
Compare
fallenatlas
force-pushed
the
524-box-to-box-collisions
branch
from
ef1f98f
to
7edb861
Compare
github-actions
bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement narrow phase collision detection for box vs box.
Checklist