Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hierarchies to the transform plugin #935

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Add hierarchies to the transform plugin #935

merged 11 commits into from
Feb 2, 2024

Conversation

luishfonseca
Copy link
Contributor

@luishfonseca luishfonseca commented Feb 1, 2024 •
edited by RiscadoA
Loading

Description

  • Adds LocalToParent component
  • Adds ChildOf relations
  • Adds all appropriate transform components to entities with at least one transform component
  • Calculates and propagates transforms down the childOf hierarchy

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@luishfonseca luishfonseca added this to the 0.1 Jammable Engine milestone Feb 1, 2024
@luishfonseca luishfonseca self-assigned this Feb 1, 2024
@luishfonseca luishfonseca linked an issue Feb 1, 2024 that may be closed by this pull request
Add hierarchies to the transform plugin #334
Closed
@luishfonseca luishfonseca force-pushed the 334-add-hierarchies-to-the-transform-plugin branch 2 times, most recently from 3e4423d to 61cdcc9 Compare February 1, 2024 13:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

PR Preview Action v1.4.6
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-935/
on branch gh-pages at 2024-02-01 23:38 UTC

RiscadoA
RiscadoA approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will add tests to this PR later

@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80a5012) 34.43% compared to head (8b6cdf4) 35.35%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   34.43%   35.35%   +0.91%     
==========================================
  Files         283      287       +4     
  Lines       23710    23895     +185     
==========================================
+ Hits         8164     8447     +283     
+ Misses      15546    15448      -98

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 334-add-hierarchies-to-the-transform-plugin branch from 61cdcc9 to 719339f Compare February 1, 2024 14:58
@luishfonseca luishfonseca force-pushed the 334-add-hierarchies-to-the-transform-plugin branch from e0690ba to 8b6cdf4 Compare February 2, 2024 10:25
@RiscadoA RiscadoA merged commit 96877c3 into main Feb 2, 2024
10 checks passed
@RiscadoA RiscadoA deleted the 334-add-hierarchies-to-the-transform-plugin branch February 2, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@DiogoMendonc-a DiogoMendonc-a Awaiting requested review from DiogoMendonc-a

@roby2014 roby2014 Awaiting requested review from roby2014

@fallenatlas fallenatlas Awaiting requested review from fallenatlas

Assignees

@luishfonseca luishfonseca

Labels
A-Engine B-Transform
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Add hierarchies to the transform plugin
2 participants
@luishfonseca @RiscadoA