Switch to new cubos system syntax #919

RiscadoA · 2024-01-31T10:20:48Z

Description

Depends on #862, will merge after it is merged.

Changes the Cubos system syntax to define the systems inline with the rest of the configuration.
Will be useful to later allow specifying the traversal direction of queries and other options, such as filtering out components.
Had to change all plugins, which means this is a gigantic PR. 😔

Checklist

Self-review changes.
Evaluate impact on the documentation.
Ensure test coverage.
~~Write new samples.~~

github-actions · 2024-01-31T11:10:21Z

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-31 19:01 UTC

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/14)

core/include/cubos/core/ecs/system/dispatcher.hpp

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (2/14)

core/include/cubos/core/ecs/system/dispatcher.hpp

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (3/14)

core/include/cubos/core/ecs/system/dispatcher.hpp

github-actions · 2024-01-31T11:15:13Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:13Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (4/14)

github-actions · 2024-01-31T11:15:25Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:25Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (5/14)

github-actions · 2024-01-31T11:15:37Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:37Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (6/14)

github-actions · 2024-01-31T11:15:49Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:15:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

codecov · 2024-01-31T11:15:52Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fa22bcd) 48.91% compared to head (8294541) 49.68%.

Files	Patch %	Lines
core/src/cubos/core/ecs/cubos.cpp	88.88%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   48.91%   49.68%   +0.76%     
==========================================
  Files         134      134              
  Lines        7999     8009      +10     
==========================================
+ Hits         3913     3979      +66     
+ Misses       4086     4030      -56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (7/14)

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (8/14)

github-actions · 2024-01-31T11:16:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:14Z

core/include/cubos/core/ecs/cubos.hpp

-        /// @return Reference to this object, for chaining.
-        template <typename F>
-        SystemBuilder& runIf(F func);
-
    private:
        core::ecs::Dispatcher& mDispatcher;


⚠️ clang-diagnostic-unused-private-field ⚠️
private field mDispatcher is not used

github-actions · 2024-01-31T11:16:14Z

core/include/cubos/core/ecs/cubos.hpp

-        /// @return Reference to this object, for chaining.
-        template <typename F>
-        SystemBuilder& runIf(F func);
-
    private:
        core::ecs::Dispatcher& mDispatcher;
        std::vector<std::string>& mTags;


⚠️ clang-diagnostic-unused-private-field ⚠️
private field mTags is not used

github-actions · 2024-01-31T11:16:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:15Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:15Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:15Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:15Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (9/14)

github-actions · 2024-01-31T11:16:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (10/14)

github-actions · 2024-01-31T11:16:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:38Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:39Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:39Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:39Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:39Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (11/14)

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:16:50Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (12/14)

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:02Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (13/14)

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:14Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:15Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:15Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (14/14)

github-actions · 2024-01-31T11:17:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:26Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

github-actions · 2024-01-31T11:17:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

    {
        // Wrap the system and put it in the pending queue
-        auto* system = new System{nullptr, std::make_shared<SystemWrapper<F>>(func), {}};
+        auto* system = new System{nullptr, func, {}};


⚠️ performance-unnecessary-value-param ⚠️
parameter func is passed by value and only copied once; consider moving it to avoid unnecessary copies

Suggested change

auto* system = new System{nullptr, func, {}};

auto* system = new System{nullptr, std::move(func), {}};

github-actions · 2024-01-31T11:17:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-        template <typename F>
-        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(F func);
+        std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> assignConditionBit(
+            std::shared_ptr<AnySystemWrapper<bool>> func);


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func);

const std::shared_ptr<AnySystemWrapper<bool>>& func);

github-actions · 2024-01-31T11:17:27Z

core/include/cubos/core/ecs/system/dispatcher.hpp

-    template <typename F>
-    std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(F func)
+    inline std::bitset<CUBOS_CORE_DISPATCHER_MAX_CONDITIONS> Dispatcher::assignConditionBit(
+        std::shared_ptr<AnySystemWrapper<bool>> func)


⚠️ performance-unnecessary-value-param ⚠️
the parameter func is copied for each invocation but only used as a const reference; consider making it a const reference

Suggested change

std::shared_ptr<AnySystemWrapper<bool>> func)

const std::shared_ptr<AnySystemWrapper<bool>>& func)

Outdated

RiscadoA added A-Core A-Engine B-ECS C-Code-Quality A section of code that is hard to understand or change labels Jan 31, 2024

RiscadoA added this to the 0.1 Jammable Engine milestone Jan 31, 2024

RiscadoA self-assigned this Jan 31, 2024

RiscadoA requested review from DiogoMendonc-a, roby2014 and fallenatlas as code owners January 31, 2024 10:20

RiscadoA linked an issue Jan 31, 2024 that may be closed by this pull request

Switch to new Cubos system syntax #896

Closed

RiscadoA force-pushed the 896-switch-to-new-cubos-system-syntax branch from fc9c30b to 0229e9f Compare January 31, 2024 11:09

github-actions bot requested changes Jan 31, 2024

View reviewed changes

github-actions bot previously requested changes Jan 31, 2024

View reviewed changes

RiscadoA added 3 commits January 31, 2024 16:53

feat(ecs): update Cubos system syntax

84accc3

test(ecs): cover some of Cubos class

0953e0e

refactor(engine): switch to new Cubos syntax

78c2555

RiscadoA added 6 commits January 31, 2024 17:22

refactor(tesseratos): switch to new Cubos syntax

ada49d0

docs(ecs): remove obsolete general sample

900cacb

docs(engine): switch samples to new Cubos syntax

b137f61

fix(assets): JSONBridge returning false on success

9e3abba

docs(assets): update JSON sample format

4819538

fix(assets): FileBridge not flushing swap stream

950bf00

RiscadoA force-pushed the 896-switch-to-new-cubos-system-syntax branch from 0229e9f to 950bf00 Compare January 31, 2024 17:22

RiscadoA added 2 commits January 31, 2024 17:30

fix(ecs): add missing move to Dispatcher

3be89de

refactor(ecs): remove unused SystemBuilder

8294541

RiscadoA merged commit 1bce7c5 into main Jan 31, 2024
10 checks passed

RiscadoA deleted the 896-switch-to-new-cubos-system-syntax branch January 31, 2024 19:00

	std::shared_ptr<AnySystemWrapper<bool>> func)
	const std::shared_ptr<AnySystemWrapper<bool>>& func)

	auto* system = new System{nullptr, func, {}};
	auto* system = new System{nullptr, std::move(func), {}};

Switch to new cubos system syntax #919

Switch to new cubos system syntax #919

Conversation

RiscadoA commented Jan 31, 2024 • edited Loading

Description

Checklist

github-actions bot commented Jan 31, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot Jan 31, 2024

RiscadoA commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

codecov bot commented Jan 31, 2024 •

edited

Loading