Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Broadphase resource with a relations solution #911

Merged

Conversation

fallenatlas
Copy link
Contributor

@fallenatlas fallenatlas commented Jan 29, 2024

Description

Replaces broad phase resource which kept possibly colliding pairs of entities with a relation between these entities.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d42f949) 48.71% compared to head (39f46c3) 49.16%.

❗ Current head 39f46c3 differs from pull request most recent head 2372ef6. Consider uploading reports for the commit 2372ef6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   48.71%   49.16%   +0.45%     
==========================================
  Files         134      132       -2     
  Lines        7955     7881      -74     
==========================================
  Hits         3875     3875              
+ Misses       4080     4006      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

engine/samples/collisions/main.cpp Outdated Show resolved Hide resolved
@fallenatlas fallenatlas force-pushed the 905-replace-broadphase-resource-with-a-relations-solution branch from a7827b6 to 39f46c3 Compare January 29, 2024 22:33
…dentify a pair of potentially colliding entities
@fallenatlas fallenatlas force-pushed the 905-replace-broadphase-resource-with-a-relations-solution branch from 39f46c3 to 2372ef6 Compare January 29, 2024 22:51
Copy link
Contributor

github-actions bot commented Jan 29, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-29 22:58 UTC

@fallenatlas fallenatlas merged commit 8461713 into main Jan 29, 2024
8 checks passed
@fallenatlas fallenatlas deleted the 905-replace-broadphase-resource-with-a-relations-solution branch January 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Broadphase resource with a relations solution
2 participants