Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile and run the engine tests on the CI #899

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Compile and run the engine tests on the CI #899

merged 3 commits into from
Jan 29, 2024

Conversation

RiscadoA
Copy link
Member

Description

Closes #564, #566 and #565.

  • Moves the doctest dependency to a new lib dir in the root directory of the repo, as it is now used by both the core and the engine.
  • Removes the obsolete AABB test that was in the engine tests dir.
  • Changes the CI to run the engine tests (there are none now though).

@RiscadoA RiscadoA added A-Engine C-Testing B-CI Related to CI actions labels Jan 25, 2024
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Jan 25, 2024
@RiscadoA RiscadoA self-assigned this Jan 25, 2024
@RiscadoA RiscadoA linked an issue Jan 25, 2024 that may be closed by this pull request
Compile and run the engine tests on the CI #566
Closed
@github-actions github-actions bot added B-Build Related to the build configuration C-Bug D-Trivial Can be done in 30 minutes labels Jan 25, 2024
@RiscadoA RiscadoA linked an issue Jan 25, 2024 that may be closed by this pull request
Fix build errors on engine tests #565
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-29 20:57 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7d9aeb) 49.16% compared to head (ae83db0) 49.16%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files         132      132           
  Lines        7881     7881           
=======================================
  Hits         3875     3875           
  Misses       4006     4006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA enabled auto-merge (rebase) January 29, 2024 19:36
@RiscadoA RiscadoA force-pushed the 566-compile-and-run-the-engine-tests-on-the-ci branch from 606ac5c to ae83db0 Compare January 29, 2024 19:36
@RiscadoA RiscadoA force-pushed the 566-compile-and-run-the-engine-tests-on-the-ci branch from ae83db0 to 25522a3 Compare January 29, 2024 20:55
@RiscadoA RiscadoA merged commit c4e58d5 into main Jan 29, 2024
7 of 8 checks passed
@RiscadoA RiscadoA deleted the 566-compile-and-run-the-engine-tests-on-the-ci branch January 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas7770 tomas7770 Awaiting requested review from tomas7770

Assignees

@RiscadoA RiscadoA

Labels
A-Engine B-Build Related to the build configuration B-CI Related to CI actions C-Bug C-Compile-Error C-Testing D-Trivial Can be done in 30 minutes
Projects
None yet
Milestone
0.1 Jammable Engine
1 participant
@RiscadoA