Integrate screenPickerPlugin with rendererPlugin #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Engine
B-Rendering
S-Blocked
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
==========================================
- Coverage 49.16% 48.43% -0.74%
==========================================
Files 132 132
Lines 7881 7773 -108
==========================================
- Hits 3875 3765 -110
- Misses 4006 4008 +2 ☔ View full report in Codecov by Sentry. |
github-actions
bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
RiscadoA
requested changes
Jan 24, 2024
RiscadoA
approved these changes
Jan 26, 2024
tomas7770
force-pushed
the
869-integrate-screenpickerplugin-with-rendererplugin
branch
from
58aef4e
to
2636958
Compare
tomas7770
deleted the
869-integrate-screenpickerplugin-with-rendererplugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draws entity indexes to the screenPickerPlugin framebuffer, allowing the plugin to actually work (for entities).
Checklist